Skip to content

2026-09-01 Infrastructure Factory structured service logs review

Reviewed Factory Argo inference JSON logging for correctness and queryability.

Work Done

Adversarially reviewed the four-file uncommitted Factory logging change and the Argo job payload, container entrypoint, histo preprocessing, viseg, and vxData SDK storage call paths. Found three concrete logging issues: non-standard JSON when mutual-information is NaN, duplicate raw tracebacks after structured error events, and missing histo service terminal events on all-skipped and all-failed runs. A follow-up review confirmed all three were fixed: uncertainty scoring now returns null for empty or non-finite values, the executable boundary preserves exit 1 without the duplicate traceback, and service configuration/summary events now have accurate semantics on the handled histo paths. Confirmed Factory lint, typecheck, and format checks pass. No target code was edited.

Lessons Learned: Pitfalls

The infrastructure index did not contain Factory-specific logging conventions. Generated Pixi environments made unrestricted source searches noisy, so searches should use git ls-files or exclude .pixi.

Lessons Learned: Improvements

A short Factory observability note would help define whether the pod stream must be strict JSONL and which lifecycle events must pair. It should also state the canonical timestamp, exception, and runtime-context field names across Factory, vxData API, and vxData SDK logs.

Navigation

Type to search…

↑↓ navigate↵ selectEsc close