Skip to content

2026-08-28 Infrastructure vxData SDK S3 structural review

Reviewed the staged vxData SDK S3 module split for behavior, imports, cycles, and packaging.

Work Done

  • Reviewed the staged vxdata-sdk refactor that moves S3 code into vxdata.sdk.s3.
  • Checked repository-wide references to the removed module paths and inspected the new import graph.
  • Ran the package tests, type checker, linter, direct module-import smoke test, and a wheel-content check.
  • Found no blocking issue. Noted a small annotation-introspection drift because two moved modules no longer enable postponed annotations.

Lessons Learned: Pitfalls

  • The general infrastructure SOP was useful for ownership context but did not contain details needed for a local structural code review.
  • The Pixi environment does not install the PEP 517 build backend, so python -m hatchling build is unavailable even though Hatchling is declared in build-system. uv build can still perform an isolated wheel build.

Lessons Learned: Improvements

  • A reusable structural-move checklist should include repository-wide old-path searches, import smoke tests, and wheel-content inspection.
  • When splitting a module, preserve module-level future imports because annotation runtime representation is observable even if function behavior is unchanged.
Navigation

Type to search…

↑↓ navigate↵ selectEsc close