Skip to content

2026-08-27 ISUP inference branch review

Reviewed feat/isup-inference for correctness, privacy, CLI behavior, and reuse.

Work Done

Reviewed feat/isup-inference against main without editing the ve2e repository. Checked the new CLI, patient preparation pipeline, checkpoint loading, forward pass, metrics, JSON output, and logging redaction against existing ve2e and data-pipeline code. Verified actionable issues around environment/package imports, label-dependent study selection, CPU device handling, logging fallback redaction, and broad platform queries.

Lessons Learned: Pitfalls

The inverse workstream has no SOP index yet, so the mandatory SOP read could not be completed. The macOS checkout cannot run the Linux-only pixi environments, which prevents native runtime tests; static source and lockfile inspection remained useful.

Lessons Learned: Improvements

Document which repository environment owns cross-project inference commands. In particular, record whether production scripts may import the separate data project and how that project must be installed. Add a small inference contract covering unlabeled patients, multiple studies, CPU support, and PHI-safe logging.

Navigation

Type to search…

↑↓ navigate↵ selectEsc close