---
title: "2026-09-17 Factory PR406 review comments"
description: "Explicit registration and published vxData dependency cleanup."
image: "https://docs.virdx.dev/img/virdx-social-card.png"
---

> Documentation Index
> Fetch the complete documentation index at: https://docs.virdx.dev/llms.txt
> Use this file to discover all available pages before exploring further.

# 2026-09-17 Factory PR406 review comments

## Work Done

Addressed both user comments on [mono #406](https://github.com/virdx/mono/pull/406)
in appended commit 1f42d46a. Seven explicit register_service calls replace
the registration table/loop; all job resources unchanged. apps/factory now uses
published conda vxdata-sdk >=4.3,<5 and its schema dependency instead of source paths.
Removed duplicated SDK runtime deps and SDK/schema COPY lines from Dockerfile.api.
Updated pixi.lock. Framework stays a local dependency while #404 is pending.
Replied to both inline comments. User framework manifest preserved byte-for-byte.

## Lessons Learned: Pitfalls

The private conda packages need an explicit conda/PyPI name mapping to satisfy
factory-framework's PEP508 dependencies. Without it, Pixi looks for vxdata-sdk
in the Python registry and fails. Pixi0.75 supports inline workspace.conda-pypi-map
entries, avoiding another mapping file. SDK installed as4.3.0; conda schemas4.3.0
currently reports Python distribution metadata4.2.0. No packaging changes here.

## Lessons Learned: Improvements

For this app, user prefers explicit registrations over deduplicating configuration
with a table/loop. Prefer released vxData packages and their dependency metadata
over hand-maintained source paths/runtime lists. Native Nx formatting/lint/types/
build, boundaries and locked startup checks passed; verified installed imports,
unchanged service resources and14routes without heavy inference imports. No cluster
or image/GPU validation in this review fix.

Source: https://docs.virdx.dev/knowledge/inbox/2026-09-17-infrastructure-factory-pr406-review-comments/index.mdx