---
title: "2026-08-25 vxData SDK telemetry review"
description: "Reviewed PR 337 telemetry design and compared its custom JSONL sink with standard Python logging."
image: "https://docs.virdx.dev/img/virdx-social-card.png"
---

> Documentation Index
> Fetch the complete documentation index at: https://docs.virdx.dev/llms.txt
> Use this file to discover all available pages before exploring further.

# 2026-08-25 vxData SDK telemetry review

## Work Done

Reviewed only the telemetry design in mono PR 337 against the requested base commit. Traced the custom `Telemetry` JSONL sink, its storage download call site, transfer statistics, tests, and client lifecycle. Recommended standard structured Python logging configured by the host application instead of an SDK-owned file sink, unless automatic `VXDATA_TELEMETRY_DIR` files are a firm requirement.

## Lessons Learned: Pitfalls

The broad infrastructure workstream material was not needed for this narrow code review. The mandatory `git pull --ff-only` failed with “Cannot fast-forward to multiple branches”; `git fetch origin main` followed by `git merge --ff-only origin/main` worked.

## Lessons Learned: Improvements

A short durable note on observability ownership would help future reviews: reusable SDKs should normally emit through standard logging and leave destinations, formatting, rotation, and shipping to applications. SDK-owned sinks need explicit close, rollover, and shared-writer semantics.

Source: https://docs.virdx.dev/knowledge/inbox/2026-08-25-infrastructure-vxdata-sdk-telemetry-review/index.mdx